Convert LibraryProperties to JavaFX #4617

Siedlerchr · 2019-01-26T19:49:21Z

Converted the library properties dialog to javafx

Drawback: The menu items also have one visible now...

Fix the encoding selection

Update screenshot

Change in CHANGELOG.md described
Tests created for changes
Manually tested changed features in running JabRef
Screenshots added in PR description (for bigger UI changes)
Ensured that the git commit message is a good one
Check documentation status (Issue created for outdated help page at help.jabref.org?)

First part of view and viewmodel

…tofx * upstream/master: Try to fix not on FX thread for search and autocomplete (#4618)

convert rest of the dialog add some new methods to preferences service

Rename to libraryproperties change separator width to make it visible Remove small font setting on save order config

tobiasdiez

Thanks, most of the new code looks good. My remarks are mostly suggestions to move a bit more of the logic to the corresponding view model, but apart from that nothing serious.

tobiasdiez · 2019-02-09T22:10:38Z

src/main/java/org/jabref/gui/Base.css

@@ -818,7 +818,7 @@

 .separator:horizontal .line {
    -fx-border-color: -jr-separator;
-    -fx-border-width: 0;
+    -fx-border-width: 0.5;


I think there is no need to have visible separators. Just use normal Labels for these section headings and increase the font-size / make them bold. (I think I have done something similar lately, but cannot remember where - there might be a "heading" class defined in the base.css)

src/main/java/org/jabref/gui/JabRefFrame.java

src/main/java/org/jabref/gui/actions/LibraryPropertiesAction.java

src/main/java/org/jabref/gui/SaveOrderConfigDisplay.java

src/main/java/org/jabref/gui/libraryproperties/LibraryPropertiesDialogView.java

…tofx * upstream/master: (30 commits) Bump applicationinsights-core from 2.3.0 to 2.3.1 (#4656) Bump applicationinsights-logging-log4j2 from 2.3.0 to 2.3.1 (#4657) Bump bcprov-jdk15on from 1.60 to 1.61 (#4653) Bump log4j-jcl from 2.11.1 to 2.11.2 (#4646) Bump log4j-api from 2.11.1 to 2.11.2 (#4650) Bump assertj-swing-junit from 3.8.0 to 3.9.2 (#4647) Bump log4j-jul from 2.11.1 to 2.11.2 (#4648) Bump log4j-slf4j18-impl from 2.11.1 to 2.11.2 (#4649) Bump log4j-core from 2.11.1 to 2.11.2 (#4651) Remove old code for PDF import (#4634) Reorder conditional checks Automatically created groups with Field to group by as entrytype (#4539) (#4555) Fix for issue 4641: Remove usage of TempDirectory extension from junit-pioneer (#4644) Edit localization file Add Integrity check for books with edition reported as 1 Use 'junit-jupiter' aggregator module (#4640) Bump junit-jupiter-params from 5.3.2 to 5.4.0 (#4638) Bump junit-vintage-engine from 5.3.2 to 5.4.0 (#4637) Bump junit-platform-launcher from 1.3.2 to 1.4.0 (#4636) Bump junit-jupiter-api from 5.3.2 to 5.4.0 (#4639) ... # Conflicts: # src/main/java/org/jabref/preferences/PreferencesService.java

…tofx * upstream/master: Convert Strings Dialog to javafx (#3735)

move setValues method to constructor create fxml draft for save order config

…tofx * upstream/master: fix copy base bug in Strings Dialog validation Bump mockito-core from 2.24.0 to 2.24.5 (#4663) Fix for #4628 - cant save new content selectors (#4658) Fix issues with double spaces. (#4662)

Use Expressions in fxml code for enabling/disabling

…tofx * upstream/master: Catch NumberFormatException in BibTeXML exporter (#4698) Remove resolve duplicate keys dialog (#4696) fixes #4610. Changed the way the GroupDialog description is displayed. (#4660) Bump slf4j-api from 1.8.0-beta2 to 1.8.0-beta4 (#4675)

…ts work move old save order config to the new class add toggle group TODO: Find out why initialize is not called

src/main/java/org/jabref/gui/SaveOrderConfigDisplayView.java

…tofx * upstream/master: Bump fontbox from 2.0.13 to 2.0.14 (#4705) Bump pdfbox from 2.0.13 to 2.0.14 (#4706) Bump xmpbox from 2.0.13 to 2.0.14 (#4704) Improve parser warnings (#4702) Bump checkstyle from 8.17 to 8.18 (#4700)

replace library properties save order config by custom component refactor

add css section header remove some old stuff

Siedlerchr · 2019-03-01T16:43:21Z

@tobiasdiez Any idea why the FieldFormaterCleanups Panel aka SaveAction is now so small at the bottom?
see screenshot in the first post.
//Fixed it

still no effect

fix l10n

remove unused variables

…tofx * upstream/master: (25 commits) Convert "Manage external file types" dialog to JavaFX (#4711) Remove add/move/remove from group dialog (#4695) Fix entry preview copy exception (#4721) Fix default import format pattern (#4731) Add key bindings (#4732) Convert "wait for save" dialog to JavaFX (#4697) Add changes to CHANGELOG and fix New Library icons Adding GENERATE_CITE_KEYS button to toolbar. Change toolbar icons and add separators Adding additional modifiers to be used in bibtex key generator Adding "von" part to Author's last name when exporting to MS Office 2007 (#4725) Bump mockito-core from 2.24.5 to 2.25.0 (#4723) remove obsolete localization strings fix checkstyle fix build cleanup convert file chooser in preferences remove unused swing stuff convert help buttons Fix #4703: Newline format couldn't be changed (#4720) Group and reorder the Main Menu (tabs & icons) (#4707) Convert Manage keywords dialog to JavaFX (#4701) ...

add comemnt fix indencation

Siedlerchr · 2019-03-08T14:44:53Z

Will rework that save Actions/cleanup stuff in a separate PR.

tobiasdiez

Thanks for the follow-up. I've only a few very minor remarks. You can merge afterwards.

tobiasdiez · 2019-03-08T14:51:13Z

src/main/java/org/jabref/gui/SaveOrderConfigDisplayView.java

+        return viewModel.getSaveOrderConfig();
+    }
+
+    public Node getJFXPanel() {


this method seems really unnecessary

tobiasdiez · 2019-03-08T14:51:31Z

src/main/java/org/jabref/gui/SaveOrderConfigDisplayView.java

+
+        ViewLoader.view(this)
+                  .root(this)
+                  .controller(this)


remove controller(this) statement as this is not required

src/main/java/org/jabref/gui/libraryproperties/LibraryPropertiesDialog.fxml

tobiasdiez · 2019-03-08T14:56:28Z

src/main/java/org/jabref/gui/preferences/PreferencesDialog.java

@@ -62,6 +64,10 @@ public PreferencesDialog(JabRefFrame parent, TaskExecutor taskExecutor) {
        setTitle(Localization.lang("JabRef preferences"));
        getDialogPane().getScene().getStylesheets().add(this.getClass().getResource("PreferencesDialog.css").toExternalForm());

+        ViewLoader.view(this)


now the above statement loading the css file should be superfluous.

Nope, the CSS specified some other preferences stuff, e.g. the side menu

src/main/java/org/jabref/preferences/JabRefPreferences.java

…tofx * upstream/master: Rework import inspection dialog in JavaFX (#4692) Use action handler (#4726) # Conflicts: # src/main/java/org/jabref/preferences/PreferencesService.java

…le order adjust tests format fxml

268df9e Create folia-biologica.csl (JabRef#4629) 2480646 Update transversalites.csl (JabRef#4624) beae5fb Update instituto-de-pesquisas-energeticas-e-nucleares.csl (JabRef#4623) d7d70d2 Create australian-journal-of-agricultural-and-resource-economics.csl (JabRef#4626) cc2c6eb Update harvard-university-of-westminster.csl (JabRef#4622) 30767b0 Create marine-turtle-newsletter.csl (JabRef#4625) a2324ac Create journal-of-new-zealand-grasslands.csl (JabRef#4628) 1a87f4b Create china-national-standard-gb-t-7714-2015-author-date.csl (JabRef#4611) 2032fef Create china-national-standard-gb-t-7714-2015-note.csl (JabRef#4610) 3e00047 Create beilstein-open-access-journals.csl (JabRef#4613) b6c3363 Update american-institute-of-aeronautics-and-astronautics.csl (JabRef#4614) cc68a6c Remove et-al settings from american-chemical-society.csl (JabRef#4615) 2393106 Create rivista-trimestrale-di-sanita-pubblica-veterinaria.csl (JabRef#4617) 5f511cd Update transversalites.csl (JabRef#4621) f052033 Create aporia.csl (JabRef#4620) ae39d97 Create the-american-journal-of-geriatric-psychiatry.csl (JabRef#4619) d61f56c Update centre-de-recherche-sur-les-civilisations-de-l-asie-orientale.csl (JabRef#4612) 9604285 Create united-nations-development-programme-icca-legal-review.csl (JabRef#4563) 79c9235 Create jiaptr.csl (JabRef#4609) a044ab2 Update groupe-danthropologie-et-darcheologie-funeraire.csl (JabRef#4599) beab323 Create haemophilia.csl (JabRef#4601) 6d7ca0a Update associacao-brasileira-de-normas-tecnicas-ufrgs.csl (JabRef#4598) 6049caa Update geistes-und-kulturwissenschaften-heilmann.csl (JabRef#4597) 9526038 journal title in italics in biophysical-journal.csl (JabRef#4595) 9ab51f9 Create the-university-of-tokyo-law-review.csl (JabRef#4593) 126f84c Always show DOI for article-journal for journal-of-forensic-sciences.csl (JabRef#4596) 265a3a9 Update john-benjamins-publishing-company-linguistik-aktuell-linguistics-today.csl (JabRef#4588) bfcd47c Update journal-of-forensic-sciences.csl (JabRef#4590) 165be9c Create laboratory-animal-science-professional.csl (JabRef#4591) b51b8e6 Create pediatric-infectious-disease-journal.csl (JabRef#4589) 1ab0241 bibtex.csl - remove creator lables 722ba77 AGLC: Remove short-title from bibliography git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 268df9e

268df9e Create folia-biologica.csl (JabRef#4629) 2480646 Update transversalites.csl (JabRef#4624) beae5fb Update instituto-de-pesquisas-energeticas-e-nucleares.csl (JabRef#4623) d7d70d2 Create australian-journal-of-agricultural-and-resource-economics.csl (JabRef#4626) cc2c6eb Update harvard-university-of-westminster.csl (JabRef#4622) 30767b0 Create marine-turtle-newsletter.csl (JabRef#4625) a2324ac Create journal-of-new-zealand-grasslands.csl (JabRef#4628) 1a87f4b Create china-national-standard-gb-t-7714-2015-author-date.csl (JabRef#4611) 2032fef Create china-national-standard-gb-t-7714-2015-note.csl (JabRef#4610) 3e00047 Create beilstein-open-access-journals.csl (JabRef#4613) b6c3363 Update american-institute-of-aeronautics-and-astronautics.csl (JabRef#4614) cc68a6c Remove et-al settings from american-chemical-society.csl (JabRef#4615) 2393106 Create rivista-trimestrale-di-sanita-pubblica-veterinaria.csl (JabRef#4617) 5f511cd Update transversalites.csl (JabRef#4621) f052033 Create aporia.csl (JabRef#4620) ae39d97 Create the-american-journal-of-geriatric-psychiatry.csl (JabRef#4619) d61f56c Update centre-de-recherche-sur-les-civilisations-de-l-asie-orientale.csl (JabRef#4612) 9604285 Create united-nations-development-programme-icca-legal-review.csl (JabRef#4563) 79c9235 Create jiaptr.csl (JabRef#4609) a044ab2 Update groupe-danthropologie-et-darcheologie-funeraire.csl (JabRef#4599) beab323 Create haemophilia.csl (JabRef#4601) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 268df9e

268df9e Create folia-biologica.csl (JabRef#4629) 2480646 Update transversalites.csl (JabRef#4624) beae5fb Update instituto-de-pesquisas-energeticas-e-nucleares.csl (JabRef#4623) d7d70d2 Create australian-journal-of-agricultural-and-resource-economics.csl (JabRef#4626) cc2c6eb Update harvard-university-of-westminster.csl (JabRef#4622) 30767b0 Create marine-turtle-newsletter.csl (JabRef#4625) a2324ac Create journal-of-new-zealand-grasslands.csl (JabRef#4628) 1a87f4b Create china-national-standard-gb-t-7714-2015-author-date.csl (JabRef#4611) 2032fef Create china-national-standard-gb-t-7714-2015-note.csl (JabRef#4610) 3e00047 Create beilstein-open-access-journals.csl (JabRef#4613) b6c3363 Update american-institute-of-aeronautics-and-astronautics.csl (JabRef#4614) cc68a6c Remove et-al settings from american-chemical-society.csl (JabRef#4615) 2393106 Create rivista-trimestrale-di-sanita-pubblica-veterinaria.csl (JabRef#4617) 5f511cd Update transversalites.csl (JabRef#4621) f052033 Create aporia.csl (JabRef#4620) ae39d97 Create the-american-journal-of-geriatric-psychiatry.csl (JabRef#4619) d61f56c Update centre-de-recherche-sur-les-civilisations-de-l-asie-orientale.csl (JabRef#4612) 9604285 Create united-nations-development-programme-icca-legal-review.csl (JabRef#4563) 79c9235 Create jiaptr.csl (JabRef#4609) a044ab2 Update groupe-danthropologie-et-darcheologie-funeraire.csl (JabRef#4599) beab323 Create haemophilia.csl (JabRef#4601) 6d7ca0a Update associacao-brasileira-de-normas-tecnicas-ufrgs.csl (JabRef#4598) 6049caa Update geistes-und-kulturwissenschaften-heilmann.csl (JabRef#4597) 9526038 journal title in italics in biophysical-journal.csl (JabRef#4595) 9ab51f9 Create the-university-of-tokyo-law-review.csl (JabRef#4593) 126f84c Always show DOI for article-journal for journal-of-forensic-sciences.csl (JabRef#4596) 265a3a9 Update john-benjamins-publishing-company-linguistik-aktuell-linguistics-today.csl (JabRef#4588) bfcd47c Update journal-of-forensic-sciences.csl (JabRef#4590) 165be9c Create laboratory-animal-science-professional.csl (JabRef#4591) b51b8e6 Create pediatric-infectious-disease-journal.csl (JabRef#4589) 1ab0241 bibtex.csl - remove creator lables 722ba77 AGLC: Remove short-title from bibliography git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 268df9e

268df9e Create folia-biologica.csl (JabRef#4629) 2480646 Update transversalites.csl (JabRef#4624) beae5fb Update instituto-de-pesquisas-energeticas-e-nucleares.csl (JabRef#4623) d7d70d2 Create australian-journal-of-agricultural-and-resource-economics.csl (JabRef#4626) cc2c6eb Update harvard-university-of-westminster.csl (JabRef#4622) 30767b0 Create marine-turtle-newsletter.csl (JabRef#4625) a2324ac Create journal-of-new-zealand-grasslands.csl (JabRef#4628) 1a87f4b Create china-national-standard-gb-t-7714-2015-author-date.csl (JabRef#4611) 2032fef Create china-national-standard-gb-t-7714-2015-note.csl (JabRef#4610) 3e00047 Create beilstein-open-access-journals.csl (JabRef#4613) b6c3363 Update american-institute-of-aeronautics-and-astronautics.csl (JabRef#4614) cc68a6c Remove et-al settings from american-chemical-society.csl (JabRef#4615) 2393106 Create rivista-trimestrale-di-sanita-pubblica-veterinaria.csl (JabRef#4617) 5f511cd Update transversalites.csl (JabRef#4621) f052033 Create aporia.csl (JabRef#4620) ae39d97 Create the-american-journal-of-geriatric-psychiatry.csl (JabRef#4619) d61f56c Update centre-de-recherche-sur-les-civilisations-de-l-asie-orientale.csl (JabRef#4612) 9604285 Create united-nations-development-programme-icca-legal-review.csl (JabRef#4563) 79c9235 Create jiaptr.csl (JabRef#4609) a044ab2 Update groupe-danthropologie-et-darcheologie-funeraire.csl (JabRef#4599) beab323 Create haemophilia.csl (JabRef#4601) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 268df9e

268df9e Create folia-biologica.csl (#4629) 2480646 Update transversalites.csl (#4624) beae5fb Update instituto-de-pesquisas-energeticas-e-nucleares.csl (#4623) d7d70d2 Create australian-journal-of-agricultural-and-resource-economics.csl (#4626) cc2c6eb Update harvard-university-of-westminster.csl (#4622) 30767b0 Create marine-turtle-newsletter.csl (#4625) a2324ac Create journal-of-new-zealand-grasslands.csl (#4628) 1a87f4b Create china-national-standard-gb-t-7714-2015-author-date.csl (#4611) 2032fef Create china-national-standard-gb-t-7714-2015-note.csl (#4610) 3e00047 Create beilstein-open-access-journals.csl (#4613) b6c3363 Update american-institute-of-aeronautics-and-astronautics.csl (#4614) cc68a6c Remove et-al settings from american-chemical-society.csl (#4615) 2393106 Create rivista-trimestrale-di-sanita-pubblica-veterinaria.csl (#4617) 5f511cd Update transversalites.csl (#4621) f052033 Create aporia.csl (#4620) ae39d97 Create the-american-journal-of-geriatric-psychiatry.csl (#4619) d61f56c Update centre-de-recherche-sur-les-civilisations-de-l-asie-orientale.csl (#4612) 9604285 Create united-nations-development-programme-icca-legal-review.csl (#4563) 79c9235 Create jiaptr.csl (#4609) a044ab2 Update groupe-danthropologie-et-darcheologie-funeraire.csl (#4599) beab323 Create haemophilia.csl (#4601) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 268df9e

268df9e Create folia-biologica.csl (JabRef#4629) 2480646 Update transversalites.csl (JabRef#4624) beae5fb Update instituto-de-pesquisas-energeticas-e-nucleares.csl (JabRef#4623) d7d70d2 Create australian-journal-of-agricultural-and-resource-economics.csl (JabRef#4626) cc2c6eb Update harvard-university-of-westminster.csl (JabRef#4622) 30767b0 Create marine-turtle-newsletter.csl (JabRef#4625) a2324ac Create journal-of-new-zealand-grasslands.csl (JabRef#4628) 1a87f4b Create china-national-standard-gb-t-7714-2015-author-date.csl (JabRef#4611) 2032fef Create china-national-standard-gb-t-7714-2015-note.csl (JabRef#4610) 3e00047 Create beilstein-open-access-journals.csl (JabRef#4613) b6c3363 Update american-institute-of-aeronautics-and-astronautics.csl (JabRef#4614) cc68a6c Remove et-al settings from american-chemical-society.csl (JabRef#4615) 2393106 Create rivista-trimestrale-di-sanita-pubblica-veterinaria.csl (JabRef#4617) 5f511cd Update transversalites.csl (JabRef#4621) f052033 Create aporia.csl (JabRef#4620) ae39d97 Create the-american-journal-of-geriatric-psychiatry.csl (JabRef#4619) d61f56c Update centre-de-recherche-sur-les-civilisations-de-l-asie-orientale.csl (JabRef#4612) 9604285 Create united-nations-development-programme-icca-legal-review.csl (JabRef#4563) 79c9235 Create jiaptr.csl (JabRef#4609) a044ab2 Update groupe-danthropologie-et-darcheologie-funeraire.csl (JabRef#4599) beab323 Create haemophilia.csl (JabRef#4601) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 268df9e

268df9e Create folia-biologica.csl (JabRef#4629) 2480646 Update transversalites.csl (JabRef#4624) beae5fb Update instituto-de-pesquisas-energeticas-e-nucleares.csl (JabRef#4623) d7d70d2 Create australian-journal-of-agricultural-and-resource-economics.csl (JabRef#4626) cc2c6eb Update harvard-university-of-westminster.csl (JabRef#4622) 30767b0 Create marine-turtle-newsletter.csl (JabRef#4625) a2324ac Create journal-of-new-zealand-grasslands.csl (JabRef#4628) 1a87f4b Create china-national-standard-gb-t-7714-2015-author-date.csl (JabRef#4611) 2032fef Create china-national-standard-gb-t-7714-2015-note.csl (JabRef#4610) 3e00047 Create beilstein-open-access-journals.csl (JabRef#4613) b6c3363 Update american-institute-of-aeronautics-and-astronautics.csl (JabRef#4614) cc68a6c Remove et-al settings from american-chemical-society.csl (JabRef#4615) 2393106 Create rivista-trimestrale-di-sanita-pubblica-veterinaria.csl (JabRef#4617) 5f511cd Update transversalites.csl (JabRef#4621) f052033 Create aporia.csl (JabRef#4620) ae39d97 Create the-american-journal-of-geriatric-psychiatry.csl (JabRef#4619) d61f56c Update centre-de-recherche-sur-les-civilisations-de-l-asie-orientale.csl (JabRef#4612) 9604285 Create united-nations-development-programme-icca-legal-review.csl (JabRef#4563) 79c9235 Create jiaptr.csl (JabRef#4609) a044ab2 Update groupe-danthropologie-et-darcheologie-funeraire.csl (JabRef#4599) beab323 Create haemophilia.csl (JabRef#4601) 6d7ca0a Update associacao-brasileira-de-normas-tecnicas-ufrgs.csl (JabRef#4598) 6049caa Update geistes-und-kulturwissenschaften-heilmann.csl (JabRef#4597) 9526038 journal title in italics in biophysical-journal.csl (JabRef#4595) 9ab51f9 Create the-university-of-tokyo-law-review.csl (JabRef#4593) 126f84c Always show DOI for article-journal for journal-of-forensic-sciences.csl (JabRef#4596) 265a3a9 Update john-benjamins-publishing-company-linguistik-aktuell-linguistics-today.csl (JabRef#4588) bfcd47c Update journal-of-forensic-sciences.csl (JabRef#4590) 165be9c Create laboratory-animal-science-professional.csl (JabRef#4591) b51b8e6 Create pediatric-infectious-disease-journal.csl (JabRef#4589) 1ab0241 bibtex.csl - remove creator lables 722ba77 AGLC: Remove short-title from bibliography git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 268df9e

268df9e Create folia-biologica.csl (JabRef#4629) 2480646 Update transversalites.csl (JabRef#4624) beae5fb Update instituto-de-pesquisas-energeticas-e-nucleares.csl (JabRef#4623) d7d70d2 Create australian-journal-of-agricultural-and-resource-economics.csl (JabRef#4626) cc2c6eb Update harvard-university-of-westminster.csl (JabRef#4622) 30767b0 Create marine-turtle-newsletter.csl (JabRef#4625) a2324ac Create journal-of-new-zealand-grasslands.csl (JabRef#4628) 1a87f4b Create china-national-standard-gb-t-7714-2015-author-date.csl (JabRef#4611) 2032fef Create china-national-standard-gb-t-7714-2015-note.csl (JabRef#4610) 3e00047 Create beilstein-open-access-journals.csl (JabRef#4613) b6c3363 Update american-institute-of-aeronautics-and-astronautics.csl (JabRef#4614) cc68a6c Remove et-al settings from american-chemical-society.csl (JabRef#4615) 2393106 Create rivista-trimestrale-di-sanita-pubblica-veterinaria.csl (JabRef#4617) 5f511cd Update transversalites.csl (JabRef#4621) f052033 Create aporia.csl (JabRef#4620) ae39d97 Create the-american-journal-of-geriatric-psychiatry.csl (JabRef#4619) d61f56c Update centre-de-recherche-sur-les-civilisations-de-l-asie-orientale.csl (JabRef#4612) 9604285 Create united-nations-development-programme-icca-legal-review.csl (JabRef#4563) 79c9235 Create jiaptr.csl (JabRef#4609) a044ab2 Update groupe-danthropologie-et-darcheologie-funeraire.csl (JabRef#4599) beab323 Create haemophilia.csl (JabRef#4601) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 268df9e

commit 497fcd7 Author: Linus Dietz <linus.dietz@tum.de> Date: Thu Mar 19 21:07:34 2020 +0100 Move Springer key to environment (JabRef#6139) commit 99183e1 Author: Christoph <siedlerkiller@gmail.com> Date: Wed Mar 18 20:28:36 2020 +0100 Add APS Fetcher (refactored) (JabRef#6143) * Add APS fetcher * Fix case sensitivity bug * Refactor ApsFetcher * Add note about APS fetcher * Refactor findFulltext() * Refactor getId() * Parameterize ApsFetcherTest * Add link to APS changelog entry * Refactor APS Fetcher * make separate tests Co-authored-by: August Janse <augustj@kth.se> commit edec608 Author: Siedlerchr <siedlerkiller@gmail.com> Date: Wed Mar 18 14:47:28 2020 +0100 trigger build commit cd051a1 Merge: 74408c0 a8abfcd Author: github actions <jabrefmail+webfeedback@gmail.com> Date: Tue Mar 17 18:08:19 2020 +0000 Merge commit 'a8abfcd2b0d94120ad32097aec74923ab1cb857f' commit a8abfcd Author: github actions <jabrefmail+webfeedback@gmail.com> Date: Tue Mar 17 18:08:19 2020 +0000 Squashed 'src/main/resources/csl-styles/' changes from 268df9e..db8bd33 db8bd33 Create journal-of-breast-cancer.csl (JabRef#4630) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: db8bd33 commit 74408c0 Author: Linus Dietz <linus.dietz@tum.de> Date: Tue Mar 17 09:42:32 2020 +0100 Dependency updates (JabRef#6138) * Jython RC * JavaFX commit eace727 Author: Oliver Kopp <kopp.dev@gmail.com> Date: Tue Mar 17 08:42:41 2020 +0100 Move "Manage field names & content" to "Edit" (JabRef#6137) commit 1b03f03 Author: Oliver Kopp <kopp.dev@gmail.com> Date: Tue Mar 17 06:46:07 2020 +0100 Remove obsolete usage of File in DatabaseContext (JabRef#6135) commit f4fe97b Author: eetian <57387212+eetian@users.noreply.github.com> Date: Mon Mar 16 22:27:36 2020 -0700 Fix warning display issue for entering a title made of two words (JabRef#6054) commit 6468f42 Merge: 2339e95 57b5833 Author: Oliver Kopp <kopp.dev@gmail.com> Date: Tue Mar 17 06:23:57 2020 +0100 Merge pull request JabRef#6128 from JabRef/fix-citeseer-test Fix fetcher test: CiteSeerTest commit 2339e95 Author: Oliver Kopp <kopp.dev@gmail.com> Date: Mon Mar 16 22:59:12 2020 +0100 Fix typo commit 98d0fa9 Author: Oliver Kopp <kopp.dev@gmail.com> Date: Mon Mar 16 22:58:12 2020 +0100 Fix typos commit fd2ac24 Author: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Date: Mon Mar 16 20:36:19 2020 +0100 Bump postgresql from 42.2.10 to 42.2.11 (JabRef#6131) Bumps [postgresql](https://github.com/pgjdbc/pgjdbc) from 42.2.10 to 42.2.11. - [Release notes](https://github.com/pgjdbc/pgjdbc/releases) - [Changelog](https://github.com/pgjdbc/pgjdbc/blob/master/CHANGELOG.md) - [Commits](pgjdbc/pgjdbc@REL42.2.10...REL42.2.11) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> commit 663815d Author: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Date: Mon Mar 16 20:35:34 2020 +0100 Bump mockito-core from 3.3.1 to 3.3.3 (JabRef#6132) Bumps [mockito-core](https://github.com/mockito/mockito) from 3.3.1 to 3.3.3. - [Release notes](https://github.com/mockito/mockito/releases) - [Commits](mockito/mockito@v3.3.1...v3.3.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> commit deb8ae8 Author: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Date: Mon Mar 16 20:35:19 2020 +0100 Bump org.beryx.jlink from 2.17.2 to 2.17.3 (JabRef#6133) Bumps org.beryx.jlink from 2.17.2 to 2.17.3. Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> commit cbd26f1 Author: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com> Date: Mon Mar 16 09:36:07 2020 +0100 Small improvements in preferences dialog (JabRef#6130) * Changed special buttons to icon buttons * Changed ComboBox lists to use proper display name and added spinner to font size * Fixed KeyPress event * Reworded biblatex to BibLaTeX * l10n * Removed obsolete special pdf treatment in preferences * CHANGELOG.md and removed forgotten bindings * Fixed wrong biblatex fix * checkstyle commit 10f5468 Author: Oliver Kopp <kopp.dev@gmail.com> Date: Mon Mar 16 09:00:04 2020 +0100 Hotfix of tests commit c7e399c Merge: 0628f11 f52bd03 Author: Oliver Kopp <kopp.dev@gmail.com> Date: Mon Mar 16 07:45:59 2020 +0100 Merge pull request JabRef#6117 from JabRef/refactor-save Refactor SaveAction commit f52bd03 Author: Oliver Kopp <kopp.dev@gmail.com> Date: Mon Mar 16 07:45:25 2020 +0100 Fix title refresh commit 57b5833 Author: Oliver Kopp <kopp.dev@gmail.com> Date: Sun Mar 15 21:52:10 2020 +0100 Fix fetcher test: CiteSeerTest commit 0628f11 Merge: a71959f 0f93e22 Author: Oliver Kopp <kopp.dev@gmail.com> Date: Sun Mar 15 20:38:31 2020 +0100 Merge pull request JabRef#6126 from JabRef/google-captcha Minor fetcher improvements commit 3f9922e Author: Stefan Kolb <stefan-kolb@web.de> Date: Sun Mar 15 18:56:50 2020 +0100 More refactorings commit 0f93e22 Author: Stefan Kolb <stefan-kolb@web.de> Date: Sun Mar 15 18:15:44 2020 +0100 Minor improvements for Google scholar fetcher Detect Google captcha div. Follow up PRs might show or give more info to the user. commit 8f68de9 Author: Stefan Kolb <stefan-kolb@web.de> Date: Sun Mar 15 15:13:05 2020 +0100 Improve arXiv fetcher commit de790f9 Author: Stefan Kolb <stefan-kolb@web.de> Date: Sun Mar 15 15:06:04 2020 +0100 Improve ACS fetcher commit a71959f Author: Stefan Kolb <stefan-kolb@web.de> Date: Sun Mar 15 15:01:32 2020 +0100 Checkstyle commit 3eeb86c Author: Stefan Kolb <stefan-kolb@web.de> Date: Sun Mar 15 15:00:17 2020 +0100 Improve SpringerLink fetcher commit 15c7981 Author: Stefan Kolb <stefan-kolb@web.de> Date: Sun Mar 15 14:52:42 2020 +0100 Improve DoiResolution fetcher commit 086629d Author: Stefan Kolb <stefan-kolb@web.de> Date: Sun Mar 15 12:55:20 2020 +0100 Improve OpenAccessDoi fetcher commit 0784b46 Merge: b5d5ed0 01de672 Author: github actions <jabrefmail+webfeedback@gmail.com> Date: Sun Mar 15 02:09:40 2020 +0000 Merge commit '01de672cc025432a6642f062a84e184d3a5408a1' commit 01de672 Author: github actions <jabrefmail+webfeedback@gmail.com> Date: Sun Mar 15 02:09:39 2020 +0000 Squashed 'src/main/resources/csl-styles/' changes from 6d7ca0a..268df9e 268df9e Create folia-biologica.csl (JabRef#4629) 2480646 Update transversalites.csl (JabRef#4624) beae5fb Update instituto-de-pesquisas-energeticas-e-nucleares.csl (JabRef#4623) d7d70d2 Create australian-journal-of-agricultural-and-resource-economics.csl (JabRef#4626) cc2c6eb Update harvard-university-of-westminster.csl (JabRef#4622) 30767b0 Create marine-turtle-newsletter.csl (JabRef#4625) a2324ac Create journal-of-new-zealand-grasslands.csl (JabRef#4628) 1a87f4b Create china-national-standard-gb-t-7714-2015-author-date.csl (JabRef#4611) 2032fef Create china-national-standard-gb-t-7714-2015-note.csl (JabRef#4610) 3e00047 Create beilstein-open-access-journals.csl (JabRef#4613) b6c3363 Update american-institute-of-aeronautics-and-astronautics.csl (JabRef#4614) cc68a6c Remove et-al settings from american-chemical-society.csl (JabRef#4615) 2393106 Create rivista-trimestrale-di-sanita-pubblica-veterinaria.csl (JabRef#4617) 5f511cd Update transversalites.csl (JabRef#4621) f052033 Create aporia.csl (JabRef#4620) ae39d97 Create the-american-journal-of-geriatric-psychiatry.csl (JabRef#4619) d61f56c Update centre-de-recherche-sur-les-civilisations-de-l-asie-orientale.csl (JabRef#4612) 9604285 Create united-nations-development-programme-icca-legal-review.csl (JabRef#4563) 79c9235 Create jiaptr.csl (JabRef#4609) a044ab2 Update groupe-danthropologie-et-darcheologie-funeraire.csl (JabRef#4599) beab323 Create haemophilia.csl (JabRef#4601) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 268df9e commit b5d5ed0 Merge: ce7bb89 c29db2e Author: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com> Date: Sat Mar 14 23:10:22 2020 +0100 Merge pull request JabRef#6121 from JabRef/allow-icons-for-groups Icons from Material design icons not recognized commit ce7bb89 Author: Siedlerchr <siedlerkiller@gmail.com> Date: Sat Mar 14 20:23:18 2020 +0100 disable fail fast for the moment to let linux and windows build mac errors due to gradle dependecny fetching error commit 571a051 Author: Stefan Kolb <stefan-kolb@users.noreply.github.com> Date: Sat Mar 14 20:14:53 2020 +0100 Fulltext file deleted when being renamed to the name differing just by letter case (JabRef#6123) Fixes JabRef#6120 commit c29db2e Author: Stefan Kolb <stefan-kolb@web.de> Date: Sat Mar 14 14:27:19 2020 +0100 Icons from Material design icons not recognized Fixes JabRef#6078 Related JabRef#5245 commit 8dd7444 Author: Siedlerchr <siedlerkiller@gmail.com> Date: Sat Mar 14 12:14:25 2020 +0100 remove mavenLocal commit d9929d8 Merge: 11d15cb 55171e6 Author: Siedlerchr <siedlerkiller@gmail.com> Date: Sat Mar 14 12:05:30 2020 +0100 Merge remote-tracking branch 'upstream/master' * upstream/master: Update CHANGELOG.md Fix inconsistent capitalisation of downloaded files Improve arXiv fetcher (JabRef#6113) commit 11d15cb Author: Siedlerchr <siedlerkiller@gmail.com> Date: Sat Mar 14 12:04:51 2020 +0100 activate cache on mac limit has been increased to 5GB commit 55171e6 Merge: 209d336 a775858 Author: Stefan Kolb <stefan-kolb@users.noreply.github.com> Date: Sat Mar 14 12:02:31 2020 +0100 Merge pull request JabRef#6119 from JabRef/lowercase-file-extension Lowercase file extension commit a775858 Author: Stefan Kolb <stefan-kolb@users.noreply.github.com> Date: Sat Mar 14 11:26:27 2020 +0100 Update CHANGELOG.md commit 45e2c84 Author: Stefan Kolb <stefan-kolb@web.de> Date: Sat Mar 14 02:15:57 2020 +0100 Fix inconsistent capitalisation of downloaded files Fixes JabRef#6115 commit b364396 Author: Oliver Kopp <kopp.dev@gmail.com> Date: Sat Mar 14 01:15:05 2020 +0100 Refactor SaveAction - Get rid of "doSave()" - Add notification for non-successful save in case of "SaveAll" - Remove deprecated "setDatabaseFile" (as we are Java8 with Path) Co-authored-by: Stefan Kolb <stefan-kolb@web.de> commit 209d336 Author: Tobias Diez <tobiasdiez@gmx.de> Date: Fri Mar 13 23:22:31 2020 +0100 Improve arXiv fetcher (JabRef#6113) No longer include the version string in the `eprint` field, as wished in https://discourse.jabref.org/t/remove-version-in-arxiv-import/1941. Also improved the arXiv identifier parser a bit. Co-authored-by: Christoph <siedlerkiller@gmail.com> commit aab7a08 Author: Oliver Kopp <kopp.dev@gmail.com> Date: Fri Mar 13 22:45:39 2020 +0100 Add CHANGELOG.md for JabRef#6112 commit d954880 Author: Oliver Kopp <kopp.dev@gmail.com> Date: Fri Mar 13 22:32:42 2020 +0100 Try to disable code comments Source: https://docs.codecov.io/docs/pull-request-comments#section-configuration commit 8b7c374 Author: Stefan Kolb <stefan-kolb@users.noreply.github.com> Date: Fri Mar 13 22:17:31 2020 +0100 fix: exception when opening already opened files (JabRef#6114) commit 3c0c518 Merge: ae30bf0 45200d3 Author: Stefan Kolb <stefan-kolb@users.noreply.github.com> Date: Fri Mar 13 22:17:24 2020 +0100 Merge pull request JabRef#6112 from JabRef/order-group-search ux: move group filter bar to top commit 45200d3 Author: Stefan Kolb <stefan-kolb@web.de> Date: Fri Mar 13 22:02:34 2020 +0100 Increase size of expand groups icon commit fe76a94 Author: Stefan Kolb <stefan-kolb@web.de> Date: Fri Mar 13 20:54:54 2020 +0100 ux: move group filter bar to top Switch search field and new group button Cleanups Co-authored-by: Oliver Kopp <kopp.dev@gmail.com> commit ae30bf0 Author: Oliver Kopp <kopp.dev@gmail.com> Date: Fri Mar 13 19:44:59 2020 +0100 Structure SUMMARY.md and add local build to jpackage.md commit b02f982 Author: Stefan Kolb <stefan-kolb@users.noreply.github.com> Date: Fri Mar 13 19:31:05 2020 +0100 Really create new lookup menu (JabRef#6111) Refs JabRef#5989 Fixes koppor#404 commit 23034ce Author: Tobias Diez <tobiasdiez@gmx.de> Date: Thu Mar 12 14:49:52 2020 +0100 Delete CustomJFXPanel.java (JabRef#6106) commit 49e4d41 Author: Tobias Diez <tobiasdiez@gmx.de> Date: Thu Mar 12 14:37:04 2020 +0100 Remove gui globals (JabRef#6103) * Remove GUIGlobals * Deprecate Globals * Fix checkstyle commit 43f533b Author: Oliver Kopp <kopp.dev@gmail.com> Date: Tue Mar 10 11:03:51 2020 +0100 Update gradle and git checkout (JabRef#6090) * Update "actions/checkout" from v1 to v2 --> See https://github.com/actions/checkout * Update gradle from 6.2.1 to 6.2.2 --> See https://docs.gradle.org/6.2.2/release-notes.html commit d5ee20b Author: Oliver Kopp <kopp.dev@gmail.com> Date: Tue Mar 10 09:06:48 2020 +0100 Disable codecov comments Documentation: https://docs.codecov.io/docs/pull-request-comments#section-disable-comment commit 52f3571 Author: Oliver Kopp <kopp.dev@gmail.com> Date: Tue Mar 10 08:28:20 2020 +0100 Add our statement on code quality commit 60958ad Author: Oliver Kopp <kopp.dev@gmail.com> Date: Tue Mar 10 08:26:48 2020 +0100 Add link to code quality. commit a299f84 Author: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Date: Mon Mar 9 19:52:30 2020 +0100 Bump xmlunit-core from 2.6.3 to 2.6.4 (JabRef#6083) Bumps [xmlunit-core](https://github.com/xmlunit/xmlunit) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/xmlunit/xmlunit/releases) - [Changelog](https://github.com/xmlunit/xmlunit/blob/master/RELEASE_NOTES.md) - [Commits](xmlunit/xmlunit@v2.6.3...v2.6.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> commit 70d4dcf Author: Christoph <siedlerkiller@gmail.com> Date: Mon Mar 9 19:51:48 2020 +0100 New translations JabRef_en.properties (Turkish) (JabRef#6079) commit deef430 Author: Siedlerchr <siedlerkiller@gmail.com> Date: Mon Mar 9 19:49:06 2020 +0100 Try again with off in codecov +semver: minor commit 0e2b1a4 Author: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Date: Mon Mar 9 19:35:04 2020 +0100 Bump xmlunit-matchers from 2.6.3 to 2.6.4 (JabRef#6082) Bumps [xmlunit-matchers](https://github.com/xmlunit/xmlunit) from 2.6.3 to 2.6.4. - [Release notes](https://github.com/xmlunit/xmlunit/releases) - [Changelog](https://github.com/xmlunit/xmlunit/blob/master/RELEASE_NOTES.md) - [Commits](xmlunit/xmlunit@v2.6.3...v2.6.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> commit 6bff936 Author: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Date: Mon Mar 9 17:31:54 2020 +0100 Bump unirest-java from 3.6.00 to 3.6.01 (JabRef#6084) Bumps [unirest-java](https://github.com/Kong/unirest-java) from 3.6.00 to 3.6.01. - [Release notes](https://github.com/Kong/unirest-java/releases) - [Changelog](https://github.com/Kong/unirest-java/blob/master/CHANGELOG.md) - [Commits](Kong/unirest-java@v3.6.00...v3.6.01) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> commit 5fc2052 Author: Oliver Kopp <kopp.dev@gmail.com> Date: Sun Mar 8 23:24:21 2020 +0100 Add some grouping on example library commit 93de138 Author: Oliver Kopp <kopp.dev@gmail.com> Date: Sun Mar 8 22:55:23 2020 +0100 Farewell Jörg - maybe you come back at some time commit 37af676 Author: Oliver Kopp <kopp.dev@gmail.com> Date: Sun Mar 8 22:29:10 2020 +0100 Fix exception when creating a new library (JabRef#6080) commit c874080 Author: Christoph <siedlerkiller@gmail.com> Date: Sat Mar 7 23:14:46 2020 +0100 New Crowdin translations (JabRef#6075) * New translations JabRef_en.properties (Chinese Simplified) * New translations JabRef_en.properties (Dutch) * New translations JabRef_en.properties (French) * New translations JabRef_en.properties (German) * New translations JabRef_en.properties (Greek) * New translations JabRef_en.properties (Danish) * New translations JabRef_en.properties (Portuguese, Brazilian) * New translations JabRef_en.properties (Turkish) * New translations JabRef_en.properties (Tagalog) * New translations JabRef_en.properties (Swedish) * New translations JabRef_en.properties (Spanish) * New translations JabRef_en.properties (Russian) * New translations JabRef_en.properties (Persian) * New translations JabRef_en.properties (Portuguese) * New translations JabRef_en.properties (Polish) * New translations JabRef_en.properties (Norwegian) * New translations JabRef_en.properties (Japanese) * New translations JabRef_en.properties (Italian) * New translations JabRef_en.properties (Indonesian) * New translations JabRef_en.properties (Vietnamese) commit 1a36304 Author: Oliver Kopp <kopp.dev@gmail.com> Date: Fri Mar 6 23:21:45 2020 +0100 Remove duplicated CHANGELOG.md line commit 3d24714 Author: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com> Date: Fri Mar 6 15:31:23 2020 +0100 [WIP] Remove BaseAction from JabRefFrame (JabRef#6056) * Added UndoRedoAction * Refactored AppendDatabaseAction * Refactored ReplaceStringAction and GenerateBibtexKeyAction * Refactored CleanupAction * Added OpenEntryEditorAction, fixed bug about selected entries without open database * Refactored AbbreviateAction, merged UnabbreviateAction, removed unused Actions * Refactored DownloadFullTextAction * Added PullChangesFromSharedAction * Added SaveAction, removed remaining deprecated OldDatabaseCommandWrapper, BaseAction and Actions * Added UndoRedoAction * Refactored AppendDatabaseAction * Refactored ReplaceStringAction and GenerateBibtexKeyAction * Refactored CleanupAction * Added OpenEntryEditorAction, fixed bug about selected entries without open database * Refactored AbbreviateAction, merged UnabbreviateAction, removed unused Actions * Refactored DownloadFullTextAction * Added PullChangesFromSharedAction * Added SaveAction, removed remaining deprecated OldDatabaseCommandWrapper, BaseAction and Actions * Removed test, added default case for codacy compliance * Removed test for notifications commit 8060338 Author: Christoph <siedlerkiller@gmail.com> Date: Fri Mar 6 14:35:25 2020 +0100 New translations JabRef_en.properties (French) (JabRef#6071) commit 55234f6 Author: JabRef <developers@jabref.org> Date: Fri Mar 6 12:22:16 2020 +0000 GitBook: [master] 23 pages modified commit b6d6b79 Merge: d9a8088 17eb38b Author: Oliver Kopp <kopp.dev@gmail.com> Date: Fri Mar 6 11:18:20 2020 +0100 Merge branch 'replace_deprecated' commit d9a8088 Author: Oliver Kopp <kopp.dev@gmail.com> Date: Fri Mar 6 10:58:32 2020 +0100 Add month normalization to AstroPhysicsFetcher (JabRef#6022) commit 9c0fa85 Author: Oliver Kopp <kopp.dev@gmail.com> Date: Fri Mar 6 10:57:43 2020 +0100 Code: Tex --> Latex (in the context of ParseLatex) (JabRef#6019) commit 548d33c Author: Stefan Kolb <stefan-kolb@users.noreply.github.com> Date: Fri Mar 6 10:57:22 2020 +0100 Shutdown should be fixed since v2.1.2 (JabRef#5993) commit 17eb38b Author: Oliver Kopp <kopp.dev@gmail.com> Date: Fri Mar 6 10:50:50 2020 +0100 Fix CHANGELOG.md order commit 11545e1 Merge: 7fda4cc ac295cb Author: Oliver Kopp <kopp.dev@gmail.com> Date: Fri Mar 6 10:50:15 2020 +0100 Merge branch 'master' into replace_deprecated commit 7fda4cc Author: David Stevens <davidstevens.nz@gmail.com> Date: Fri Mar 6 10:49:15 2020 +0100 Add ShortScience integration (JabRef#6018) commit ac295cb Author: Oliver Kopp <kopp.dev@gmail.com> Date: Fri Mar 6 10:33:38 2020 +0100 Shorten CHANGELOG.md intro text commit 3839110 Author: Oliver Kopp <kopp.dev@gmail.com> Date: Fri Mar 6 10:32:51 2020 +0100 Show development information commit 2e6f433 Author: Oliver Kopp <kopp.dev@gmail.com> Date: Fri Mar 6 06:57:35 2020 +0100 Trigger build commit 60ff83a Author: Oliver Kopp <kopp.dev@gmail.com> Date: Fri Mar 6 09:43:06 2020 +0100 Fix -ci suffix removal commit 289142f Author: Oliver Kopp <kopp.dev@gmail.com> Date: Fri Mar 6 09:02:47 2020 +0100 Trigger build commit a3d67cc Author: Christoph <siedlerkiller@gmail.com> Date: Fri Mar 6 09:02:00 2020 +0100 Fix exception when adding save action without selected formatter (JabRef#6072) commit b28626b Author: github actions <jabrefmail+webfeedback@gmail.com> Date: Fri Mar 6 05:58:21 2020 +0000 Squashed 'src/main/resources/csl-styles/' changes from 265a3a9..6d7ca0a 6d7ca0a Update associacao-brasileira-de-normas-tecnicas-ufrgs.csl (JabRef#4598) 6049caa Update geistes-und-kulturwissenschaften-heilmann.csl (JabRef#4597) 9526038 journal title in italics in biophysical-journal.csl (JabRef#4595) 9ab51f9 Create the-university-of-tokyo-law-review.csl (JabRef#4593) 126f84c Always show DOI for article-journal for journal-of-forensic-sciences.csl (JabRef#4596) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 6d7ca0a commit fdd8797 Merge: b81d248 b28626b Author: github actions <jabrefmail+webfeedback@gmail.com> Date: Fri Mar 6 05:58:21 2020 +0000 Merge commit 'b28626b0a31006c25574f641fb4cb2b6c194d1cd' commit b81d248 Author: Oliver Kopp <kopp.dev@gmail.com> Date: Fri Mar 6 06:57:35 2020 +0100 Trigger build commit 35c3c95 Author: Oliver Kopp <kopp.dev@gmail.com> Date: Fri Mar 6 06:13:38 2020 +0100 Fix release date commit 20e76a3 Author: Oliver Kopp <kopp.dev@gmail.com> Date: Fri Mar 6 06:51:49 2020 +0100 Explicitly list more external libraries commit b676228 Author: Oliver Kopp <kopp.dev@gmail.com> Date: Thu Mar 5 06:37:40 2020 +0100 Ignore extracted JDK 14 commit 22173da Author: Oliver Kopp <kopp.dev@gmail.com> Date: Fri Mar 6 05:46:00 2020 +0100 Revert "Update JDK14 from 34 to Build 36 (2020/2/6) - Release Candidate" This reverts commit fd08f8d. commit 3ac6331 Author: Tobias Diez <tobiasdiez@gmx.de> Date: Thu Mar 5 11:00:26 2020 +0100 Disable codecov comments commit 84b1d5b Author: Tobias Diez <tobiasdiez@gmx.de> Date: Thu Mar 5 10:51:05 2020 +0100 Updated screenshot and added hint on the FAQ (JabRef#6058) commit 819df76 Author: Tobias Diez <tobiasdiez@gmx.de> Date: Thu Mar 5 09:57:17 2020 +0100 Readd package portable commit a209399 Author: Tobias Diez <tobiasdiez@gmx.de> Date: Thu Mar 5 09:51:26 2020 +0100 Add debug output commit d8ef173 Merge: d27867f 4bdedcb Author: Oliver Kopp <kopp.dev@gmail.com> Date: Thu Mar 5 06:09:33 2020 +0100 Merge branch 'master' of github.com:JabRef/jabref commit d27867f Author: Oliver Kopp <kopp.dev@gmail.com> Date: Thu Mar 5 06:08:01 2020 +0100 Move snap publishing to own workflow commit 4bdedcb Merge: 6a4fa61 dbd4865 Author: github actions <jabrefmail+webfeedback@gmail.com> Date: Thu Mar 5 05:00:53 2020 +0000 Merge commit 'dbd48659bba98c38d48b902641cfda93aa211a61' commit dbd4865 Author: github actions <jabrefmail+webfeedback@gmail.com> Date: Thu Mar 5 05:00:53 2020 +0000 Squashed 'src/main/resources/csl-locales/' changes from 2b94bf9fac..d0ee4d13c9 d0ee4d13c9 Update CONTRIBUTING.md git-subtree-dir: src/main/resources/csl-locales git-subtree-split: d0ee4d13c942648c2c88629aeb01f03a17fac72c commit cd70746 Author: Oliver Kopp <kopp.dev@gmail.com> Date: Wed Mar 4 22:52:48 2020 +0100 Remove obsolete step commit 1d6887e Author: Oliver Kopp <kopp.dev@gmail.com> Date: Wed Mar 4 22:35:33 2020 +0100 Add debug output for snap file location commit ecf822e Author: Oliver Kopp <kopp.dev@gmail.com> Date: Wed Mar 4 22:20:31 2020 +0100 Try to build snapcraft image also on master-release commit 29ed8fe Merge: d8e4c11 1a7a4df Author: Oliver Kopp <kopp.dev@gmail.com> Date: Wed Mar 4 22:16:35 2020 +0100 Merge remote-tracking branch 'origin/snapcraft-publish-action' into master-release commit 1a7a4df Author: Oliver Kopp <kopp.dev@gmail.com> Date: Wed Mar 4 22:08:50 2020 +0100 Build snap only for master branch commit d8e4c11 Author: Oliver Kopp <kopp.dev@gmail.com> Date: Wed Mar 4 17:40:22 2020 +0100 Update GitVersion action from v0.3 to v0.9.1 (JabRef#6061) commit 6a4fa61 Author: Oliver Kopp <kopp.dev@gmail.com> Date: Wed Mar 4 17:44:23 2020 +0100 Add empty line to deployment.yml to trigger build commit 2a13674 Author: Oliver Kopp <kopp.dev@gmail.com> Date: Tue Mar 3 21:41:03 2020 +0100 Release v5.0 commit 6a4df6f Author: Oliver Kopp <kopp.dev@gmail.com> Date: Wed Mar 4 21:07:57 2020 +0100 Refine external-libraries.txt commit 3d9eccc Author: Oliver Kopp <kopp.dev@gmail.com> Date: Wed Mar 4 20:53:48 2020 +0100 Revert "Remove ci prefix for releases" This reverts commit 8660e29. commit 2978dee Author: Oliver Kopp <kopp.dev@gmail.com> Date: Wed Mar 4 20:53:12 2020 +0100 Remove suffix "-ci.1" from version information stored in BuildInfo commit 8660e29 Author: Tobias Diez <tobiasdiez@gmx.de> Date: Wed Mar 4 20:06:15 2020 +0100 Remove ci prefix for releases commit 8fdfcfa Author: Galileo Sartor <galileo.sartor@gmail.com> Date: Wed Mar 4 16:40:10 2020 +0100 Use github action to publish snap commit 21c6e5e Author: Galileo Sartor <galileo.sartor@gmail.com> Date: Wed Mar 4 15:19:56 2020 +0100 snap: fix for native-messaging-host permissions (JabRef#6062) * snap: fix for native-messaging-host permissions add hook for chrome/chromium * snap: fix no newline * Add snap browser integration to changelog commit 8111707 Author: Oliver Kopp <kopp.dev@gmail.com> Date: Wed Mar 4 01:13:45 2020 +0100 Refine list of external libraries commit fd08f8d Author: Oliver Kopp <kopp.dev@gmail.com> Date: Tue Mar 3 23:05:00 2020 +0100 Update JDK14 from 34 to Build 36 (2020/2/6) - Release Candidate Source: https://jdk.java.net/14/ commit 3f9a508 Author: Oliver Kopp <kopp.dev@gmail.com> Date: Tue Mar 3 21:46:57 2020 +0100 Also release a binary in the "master-release" branch (which is to test releases) commit e7d3f0b Author: Oliver Kopp <kopp.dev@gmail.com> Date: Tue Mar 3 21:27:23 2020 +0100 Refine CHANGELOG.md (markdown-lint) commit ffef04a Author: Oliver Kopp <kopp.dev@gmail.com> Date: Tue Mar 3 20:39:24 2020 +0100 Add authors commit 7f3c556 Author: Oliver Kopp <kopp.dev@gmail.com> Date: Tue Mar 3 20:41:30 2020 +0100 Add authors of 5fa1dcf commit eb521ad Author: Christoph <siedlerkiller@gmail.com> Date: Tue Mar 3 23:10:38 2020 +0100 New Crowdin translations (JabRef#6059) commit d88df2b Author: Oliver Kopp <kopp.dev@gmail.com> Date: Tue Mar 3 23:00:58 2020 +0100 Lint README.md commit 01fdf59 Merge: adce9b9 ed0c6d8 Author: github actions <jabrefmail+webfeedback@gmail.com> Date: Tue Mar 3 20:42:27 2020 +0000 Merge commit 'ed0c6d8616adcd46491588910d63d86ef1f3dfdc' commit ed0c6d8 Author: github actions <jabrefmail+webfeedback@gmail.com> Date: Tue Mar 3 20:42:26 2020 +0000 Squashed 'src/main/resources/csl-styles/' changes from 1ab0241..265a3a9 265a3a9 Update john-benjamins-publishing-company-linguistik-aktuell-linguistics-today.csl (JabRef#4588) bfcd47c Update journal-of-forensic-sciences.csl (JabRef#4590) 165be9c Create laboratory-animal-science-professional.csl (JabRef#4591) b51b8e6 Create pediatric-infectious-disease-journal.csl (JabRef#4589) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 265a3a9 commit adce9b9 Author: Jonas Lähnemann <jonas@pdi-berlin.de> Date: Tue Mar 3 21:16:01 2020 +0100 JournalList: Minor corrections (JabRef#6043) * Corrections to Physics Status Solidi Wrong abbreviations were coming last and thus took precedence over the correct ones in the unabbreviator. commit a03bad1 Author: github actions <jabrefmail+webfeedback@gmail.com> Date: Tue Mar 3 14:42:15 2020 +0000 Squashed 'src/main/resources/csl-styles/' changes from 566df87..1ab0241 1ab0241 bibtex.csl - remove creator lables 722ba77 AGLC: Remove short-title from bibliography git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 1ab0241 commit 6731c43 Merge: f908883 a03bad1 Author: github actions <jabrefmail+webfeedback@gmail.com> Date: Tue Mar 3 14:42:15 2020 +0000 Merge commit 'a03bad1ac7bdae078bf49a072cc33f74e444e986' commit c0abdce Merge: 789799b f908883 Author: Carl Christian Snethlage <cc.snethlage@gmail.com> Date: Tue Mar 3 15:40:40 2020 +0100 Merge remote-tracking branch 'upstream/master' into replace_deprecated commit f908883 Author: Tobias Diez <tobiasdiez@gmx.de> Date: Mon Mar 2 22:20:39 2020 +0100 Add use statement for mariadb. Fixes JabRef#5886. commit e6e2da3 Author: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Date: Mon Mar 2 13:18:55 2020 +0100 Bump jsoup from 1.12.2 to 1.13.1 (JabRef#6052) Bumps [jsoup](https://github.com/jhy/jsoup) from 1.12.2 to 1.13.1. - [Release notes](https://github.com/jhy/jsoup/releases) - [Changelog](https://github.com/jhy/jsoup/blob/master/CHANGES) - [Commits](jhy/jsoup@1.12.2...jsoup-1.13.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> commit d48182d Author: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Date: Mon Mar 2 13:18:15 2020 +0100 Bump checkstyle from 8.29 to 8.30 (JabRef#6051) Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 8.29 to 8.30. - [Release notes](https://github.com/checkstyle/checkstyle/releases) - [Commits](checkstyle/checkstyle@checkstyle-8.29...checkstyle-8.30) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> commit 0128932 Author: Oliver Kopp <kopp.dev@gmail.com> Date: Sun Mar 1 22:06:53 2020 +0100 Update year commit 0d14227 Author: Christoph <siedlerkiller@gmail.com> Date: Sun Mar 1 21:34:43 2020 +0100 Fix fetcher tests using correct month (JabRef#6050) commit 7804dbb Author: Christoph <siedlerkiller@gmail.com> Date: Sun Mar 1 21:17:00 2020 +0100 New Crowdin translations (JabRef#6047) commit ed5309b Author: github actions <jabrefmail+webfeedback@gmail.com> Date: Sun Mar 1 02:09:45 2020 +0000 Squashed 'src/main/resources/csl-locales/' changes from d73af4a3fe..2b94bf9fac 2b94bf9fac Fix markdown lint error "[no-literal-urls] Don’t use literal URLs without angle brackets" (JabRef#203) git-subtree-dir: src/main/resources/csl-locales git-subtree-split: 2b94bf9fac34a2f6b73f4d320144e5c0cb8a05bc commit 4902c40 Merge: 8e26bd8 ed5309b Author: github actions <jabrefmail+webfeedback@gmail.com> Date: Sun Mar 1 02:09:45 2020 +0000 Merge commit 'ed5309bc4dcdd904b82876f4bcc5e912b94770e5' commit 6d8efb6 Author: github actions <jabrefmail+webfeedback@gmail.com> Date: Sun Mar 1 02:09:42 2020 +0000 Squashed 'src/main/resources/csl-styles/' changes from f03dece..566df87 566df87 Create archeologicke-rozhledy.csl (JabRef#4586) 4205586 Update mcgill-en.csl - include render-legislation macro (JabRef#4579) 7d857f1 Create journal-of-plankton-research.csl (JabRef#4581) 05c8aca Update mercator-institut-fur-sprachforderung-und-deutsch-als-zweitsprache.csl (JabRef#4582) 564dc5f Update vodohospodarske-technicko-ekonomicke-informace.csl (JabRef#4584) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: 566df87 commit 8e26bd8 Merge: be9c788 6d8efb6 Author: github actions <jabrefmail+webfeedback@gmail.com> Date: Sun Mar 1 02:09:42 2020 +0000 Merge commit '6d8efb6e8915b1fe16a9fa9c36b7953370395b44' commit be9c788 Author: Oliver Kopp <kopp.dev@gmail.com> Date: Sat Feb 29 09:39:25 2020 +0100 Rephrase IntelliJ paragraph commit 13c1ff6 Author: Oliver Kopp <kopp.dev@gmail.com> Date: Sat Feb 29 09:35:30 2020 +0100 Update gradle from 6.2 to 6.2.1 (JabRef#6048) commit 789799b Author: Carl Christian Snethlage <cc.snethlage@gmail.com> Date: Fri Feb 28 19:16:52 2020 +0100 Fixed merge error commit e4136b5 Merge: 88ca460 1ab300b Author: Carl Christian Snethlage <cc.snethlage@gmail.com> Date: Fri Feb 28 18:26:51 2020 +0100 Merge remote-tracking branch 'upstream/master' into replace_deprecated commit 88ca460 Merge: 3c7da13 9424777 Author: Carl Christian Snethlage <cc.snethlage@gmail.com> Date: Fri Feb 28 11:48:05 2020 +0100 Merge remote-tracking branch 'upstream/master' into replace_deprecated # Conflicts: # src/main/java/org/jabref/gui/JabRefFrame.java commit 3c7da13 Author: Carl Christian Snethlage <cc.snethlage@gmail.com> Date: Thu Feb 27 13:01:49 2020 +0100 Fixed import order commit 2719c92 Author: Carl Christian Snethlage <cc.snethlage@gmail.com> Date: Thu Feb 27 10:29:38 2020 +0100 CodeCov and moved EditAction to edit package commit da1b689 Merge: 16409e3 1d4efaa Author: Carl Christian Snethlage <cc.snethlage@gmail.com> Date: Thu Feb 27 08:53:46 2020 +0100 Merge remote-tracking branch 'upstream/master' into replace_deprecated commit 16409e3 Author: Carl Christian Snethlage <cc.snethlage@gmail.com> Date: Sun Feb 23 17:41:28 2020 +0100 l10n commit dcdef68 Author: Carl Christian Snethlage <cc.snethlage@gmail.com> Date: Sun Feb 23 17:22:12 2020 +0100 Extracted BaseAction out of EditAction commit a800bf4 Author: Carl Christian Snethlage <cc.snethlage@gmail.com> Date: Sat Feb 22 19:42:47 2020 +0100 Fixed possible NPE in SpecialFieldAction commit a5bf6b7 Author: Carl Christian Snethlage <cc.snethlage@gmail.com> Date: Sat Feb 22 19:27:30 2020 +0100 Extracted BaseAction out of SpecialFieldMenuItemFactory commit c84be95 Merge: 9b8e385 d38f813 Author: Carl Christian Snethlage <cc.snethlage@gmail.com> Date: Sat Feb 22 15:29:48 2020 +0100 Merge remote-tracking branch 'upstream/master' into replace_deprecated # Conflicts: # src/main/java/org/jabref/gui/JabRefFrame.java commit 9b8e385 Author: Carl Christian Snethlage <cc.snethlage@gmail.com> Date: Thu Feb 20 23:40:10 2020 +0100 CHANGELOG.md commit 08fa945 Author: Carl Christian Snethlage <cc.snethlage@gmail.com> Date: Thu Feb 20 14:18:37 2020 +0100 Fixed l10n merge errors commit 1dc67db Merge: bca3a0b 5fa1dcf Author: Carl Christian Snethlage <cc.snethlage@gmail.com> Date: Thu Feb 20 14:09:29 2020 +0100 Merge remote-tracking branch 'upstream/master' into replace_deprecated # Conflicts: # src/main/resources/l10n/JabRef_en.properties commit bca3a0b Author: Carl Christian Snethlage <cc.snethlage@gmail.com> Date: Thu Feb 20 14:08:32 2020 +0100 Refactored ActionHelper, removed some deprecated Actions and minor corrections commit f922be3 Merge: def0e67 c768697 Author: Carl Christian Snethlage <cc.snethlage@gmail.com> Date: Wed Feb 19 17:20:20 2020 +0100 Merge remote-tracking branch 'upstream/master' into replace_deprecated # Conflicts: # src/main/resources/l10n/JabRef_en.properties commit def0e67 Author: Carl Christian Snethlage <cc.snethlage@gmail.com> Date: Wed Feb 19 17:11:58 2020 +0100 l10n and some minor corrections commit b83d547 Author: Carl Christian Snethlage <cc.snethlage@gmail.com> Date: Wed Feb 19 00:34:41 2020 +0100 Refactored CopyBibTeXKeyAndLinkAction, copyTitle, copyCiteKey, copyKey, copyKeyAndTitle to CopyMoreActions commit e1a6e78 Author: Carl Christian Snethlage <cc.snethlage@gmail.com> Date: Tue Feb 18 21:41:58 2020 +0100 Refactored CitationStyleToClipboardWorkerTest to CopyCitationAction commit 18a3439 Author: Carl Christian Snethlage <cc.snethlage@gmail.com> Date: Tue Feb 18 20:41:42 2020 +0100 Refactored AttachFileAction commit b71360b Author: Carl Christian Snethlage <cc.snethlage@gmail.com> Date: Tue Feb 18 20:32:52 2020 +0100 Refactored SendAsEMailAction commit f664d10 Author: Carl Christian Snethlage <cc.snethlage@gmail.com> Date: Tue Feb 18 18:41:18 2020 +0100 Added OpenUrlAction, Refactored MergeEntriesAction, MergeWitchFetchedEntryAction, AttachFileAction commit d1d74c7 Author: Carl Christian Snethlage <cc.snethlage@gmail.com> Date: Mon Feb 17 23:14:23 2020 +0100 OpenConsole, OpenFolder, OpenExternalFile commit 0d2efc4 Author: Carl Christian Snethlage <cc.snethlage@gmail.com> Date: Mon Feb 17 20:45:10 2020 +0100 Preview and XMPWriter

db8bd33 Create journal-of-breast-cancer.csl (JabRef#4630) 268df9e Create folia-biologica.csl (JabRef#4629) 2480646 Update transversalites.csl (JabRef#4624) beae5fb Update instituto-de-pesquisas-energeticas-e-nucleares.csl (JabRef#4623) d7d70d2 Create australian-journal-of-agricultural-and-resource-economics.csl (JabRef#4626) cc2c6eb Update harvard-university-of-westminster.csl (JabRef#4622) 30767b0 Create marine-turtle-newsletter.csl (JabRef#4625) a2324ac Create journal-of-new-zealand-grasslands.csl (JabRef#4628) 1a87f4b Create china-national-standard-gb-t-7714-2015-author-date.csl (JabRef#4611) 2032fef Create china-national-standard-gb-t-7714-2015-note.csl (JabRef#4610) 3e00047 Create beilstein-open-access-journals.csl (JabRef#4613) b6c3363 Update american-institute-of-aeronautics-and-astronautics.csl (JabRef#4614) cc68a6c Remove et-al settings from american-chemical-society.csl (JabRef#4615) 2393106 Create rivista-trimestrale-di-sanita-pubblica-veterinaria.csl (JabRef#4617) 5f511cd Update transversalites.csl (JabRef#4621) f052033 Create aporia.csl (JabRef#4620) ae39d97 Create the-american-journal-of-geriatric-psychiatry.csl (JabRef#4619) d61f56c Update centre-de-recherche-sur-les-civilisations-de-l-asie-orientale.csl (JabRef#4612) 9604285 Create united-nations-development-programme-icca-legal-review.csl (JabRef#4563) 79c9235 Create jiaptr.csl (JabRef#4609) a044ab2 Update groupe-danthropologie-et-darcheologie-funeraire.csl (JabRef#4599) beab323 Create haemophilia.csl (JabRef#4601) 6d7ca0a Update associacao-brasileira-de-normas-tecnicas-ufrgs.csl (JabRef#4598) 6049caa Update geistes-und-kulturwissenschaften-heilmann.csl (JabRef#4597) 9526038 journal title in italics in biophysical-journal.csl (JabRef#4595) 9ab51f9 Create the-university-of-tokyo-law-review.csl (JabRef#4593) 126f84c Always show DOI for article-journal for journal-of-forensic-sciences.csl (JabRef#4596) 265a3a9 Update john-benjamins-publishing-company-linguistik-aktuell-linguistics-today.csl (JabRef#4588) bfcd47c Update journal-of-forensic-sciences.csl (JabRef#4590) 165be9c Create laboratory-animal-science-professional.csl (JabRef#4591) b51b8e6 Create pediatric-infectious-disease-journal.csl (JabRef#4589) 1ab0241 bibtex.csl - remove creator lables 722ba77 AGLC: Remove short-title from bibliography 566df87 Create archeologicke-rozhledy.csl (JabRef#4586) 4205586 Update mcgill-en.csl - include render-legislation macro (JabRef#4579) 7d857f1 Create journal-of-plankton-research.csl (JabRef#4581) 05c8aca Update mercator-institut-fur-sprachforderung-und-deutsch-als-zweitsprache.csl (JabRef#4582) 564dc5f Update vodohospodarske-technicko-ekonomicke-informace.csl (JabRef#4584) git-subtree-dir: src/main/resources/csl-styles git-subtree-split: db8bd33

Siedlerchr added 3 commits January 26, 2019 20:49

[WIP] Convert LibraryProperties to JavaFX

e18d236

First part of view and viewmodel

Merge remote-tracking branch 'upstream/master' into libraryproperties…

7f1c32b

…tofx * upstream/master: Try to fix not on FX thread for search and autocomplete (#4618)

fix l10n and error in fxml

c540ff4

convert rest of the dialog add some new methods to preferences service

Siedlerchr mentioned this pull request Jan 28, 2019

Cannot add TeX macros to text fields #4616

Closed

Siedlerchr added 2 commits January 28, 2019 18:46

Convert db properties to javafx

e82abdd

Rename to libraryproperties change separator width to make it visible Remove small font setting on save order config

fix checkstyle and l10n

d246d37

Siedlerchr changed the title ~~[WIP] Convert LibraryProperties to JavaFX~~ Convert LibraryProperties to JavaFX Jan 28, 2019

Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jan 28, 2019

Siedlerchr mentioned this pull request Feb 4, 2019

Convert/rework rest of the Swing Dialogs to javafx #3861

Closed

36 tasks

tobiasdiez requested changes Feb 9, 2019

View reviewed changes

Siedlerchr added 5 commits February 16, 2019 18:28

Merge remote-tracking branch 'upstream/master' into libraryproperties…

e9db4bf

…tofx * upstream/master: Convert Strings Dialog to javafx (#3735)

fix package error

06ed9ec

move setValues method to constructor create fxml draft for save order config

add new fxml

49e3600

Siedlerchr removed the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Feb 20, 2019

Siedlerchr changed the title ~~Convert LibraryProperties to JavaFX~~ [WIP] Convert LibraryProperties to JavaFX Feb 20, 2019

Siedlerchr added 3 commits February 21, 2019 19:17

Create properties in view Model for SaveOrderConfig

5657fed

Use Expressions in fxml code for enabling/disabling

create empty dialog pane for preferences dialog to make root componen…

159c48a

…ts work move old save order config to the new class add toggle group TODO: Find out why initialize is not called

Siedlerchr commented Feb 24, 2019

View reviewed changes

src/main/java/org/jabref/gui/SaveOrderConfigDisplayView.java Outdated Show resolved Hide resolved

Siedlerchr added 5 commits February 25, 2019 12:02

fix checkstyle

20d6c05

add missing controller and fix disable property

8db78c2

remove old save order config display

760a6c2

replace library properties save order config by custom component refactor

some layout stuff

28d3f56

add css section header remove some old stuff

Siedlerchr added 3 commits March 1, 2019 17:49

reduce sizes

1a05b8f

still no effect

add method for changing the radio button texts to save

0cf3c87

fix l10n

move radio button toggle group back as property

9e9450f

remove unused variables

store values for sort order radio box

028cbc1

Siedlerchr changed the title ~~[WIP] Convert LibraryProperties to JavaFX~~ Convert LibraryProperties to JavaFX Mar 8, 2019

Siedlerchr added 2 commits March 8, 2019 15:36

move css rule to base.css

5ce22f2

add comemnt fix indencation

Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Mar 8, 2019

tobiasdiez requested changes Mar 8, 2019

View reviewed changes

Siedlerchr added 4 commits March 9, 2019 12:47

fix css

e214240

Merge remote-tracking branch 'upstream/master' into libraryproperties…

c1707d9

…tofx * upstream/master: Rework import inspection dialog in JavaFX (#4692) Use action handler (#4726) # Conflicts: # src/main/java/org/jabref/preferences/PreferencesService.java

introduce second boolean for export in specified order to reflect tab…

28d46fd

…le order adjust tests format fxml

remove empty line

ab9de54

Siedlerchr merged commit e16d115 into master Mar 9, 2019

Siedlerchr deleted the librarypropertiestofx branch March 9, 2019 13:15

luizphilipe2 mentioned this pull request Jun 26, 2021

Convert AutoLinkFilesAction to JavafX luizphilipe2/jabref_experiment#32

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert LibraryProperties to JavaFX #4617

Convert LibraryProperties to JavaFX #4617

Siedlerchr commented Jan 26, 2019 •

edited

Loading

tobiasdiez left a comment

tobiasdiez Feb 9, 2019

Siedlerchr commented Mar 1, 2019 •

edited

Loading

Siedlerchr commented Mar 8, 2019

tobiasdiez left a comment

tobiasdiez Mar 8, 2019

tobiasdiez Mar 8, 2019

tobiasdiez Mar 8, 2019

Siedlerchr Mar 9, 2019

Convert LibraryProperties to JavaFX #4617

Convert LibraryProperties to JavaFX #4617

Conversation

Siedlerchr commented Jan 26, 2019 • edited Loading

tobiasdiez left a comment

Choose a reason for hiding this comment

tobiasdiez Feb 9, 2019

Choose a reason for hiding this comment

Siedlerchr commented Mar 1, 2019 • edited Loading

Siedlerchr commented Mar 8, 2019

tobiasdiez left a comment

Choose a reason for hiding this comment

tobiasdiez Mar 8, 2019

Choose a reason for hiding this comment

tobiasdiez Mar 8, 2019

Choose a reason for hiding this comment

tobiasdiez Mar 8, 2019

Choose a reason for hiding this comment

Siedlerchr Mar 9, 2019

Choose a reason for hiding this comment

Siedlerchr commented Jan 26, 2019 •

edited

Loading

Siedlerchr commented Mar 1, 2019 •

edited

Loading